Custom Query (1173 matches)
Results (283 - 285 of 1173)
| Ticket | Resolution | Summary | Owner | Reporter |
|---|---|---|---|---|
| #1021 | fixed | Deleting an image breaks API feeds | ||
| Description |
After deleting an image from the web interface, the /api/user/<nickname>/{inbox,feed} feeds returns http error 500 Error in log: Error - <type 'exceptions.AttributeError'>: 'NoneType' object has no attribute 'serialize' URL: http://mediagoblin.jonash.local/api/user/kabniel/feed File '/srv/mediagoblin.local/mediagoblin/local/lib/python2.7/site-packages/Paste-1.7.5.1-py2.7.egg/paste/exceptions/errormiddleware.py', line 144 in __call__ app_iter = self.application(environ, sr_checker) File '/srv/mediagoblin.local/mediagoblin/mediagoblin/app.py', line 268 in __call__ return self.call_backend(environ, start_response) File '/srv/mediagoblin.local/mediagoblin/local/lib/python2.7/site-packages/Werkzeug-0.9.6-py2.7.egg/werkzeug/wsgi.py', line 588 in __call__ return self.app(environ, start_response) File '/srv/mediagoblin.local/mediagoblin/mediagoblin/app.py', line 245 in call_backend response = controller(request) File '/srv/mediagoblin.local/mediagoblin/mediagoblin/decorators.py', line 427 in wrapper return controller(request, *args, **kwargs) File '/srv/mediagoblin.local/mediagoblin/mediagoblin/federation/views.py', line 359 in feed_endpoint feed["items"].append(activity.serialize(request)) File '/srv/mediagoblin.local/mediagoblin/mediagoblin/db/mixin.py', line 455 in serialize "object": self.get_object.serialize(request), AttributeError: 'NoneType' object has no attribute 'serialize' |
|||
| #343 | FIXED | Deleting media can become tricky | ||
| Description |
The changes in Issue `#582 </issues/582>`_ introduced some
interesting code:
::
def user_may_delete_media(controller):
...
uploader = request.db.MediaEntry.find_one(
{'slug': request.matchdict['media']}).get_uploader()
If two people have the same slug, this query will not always do the
right thing(TM).
That said, I'd really prefer things like "edit" and "delete" use
the id instead of the slug. It just feels safer and will avoid all
these slug duplicates/etc issuess.
I don't see anyone needing to bookmark the delete page? And
bookmarking the edit page might have rare use cases, so those
should be able to live with ugly urls.
For performance/safety reasons, we could consider to have an extra
decorator for finding the media only by user/id or somesuch.
|
|||
| #1038 | duplicate | Deleting media causes feed API issue | ||
| Description |
When you delete some media the activity can no longer be correctly serialized because the mediaentry/collection/etc. has been deleted. This shouldn't happen in the future because deletion will cause soft deletions but a fix needs to be put in place for those who's media has been deleted. |
|||
