Custom Query (1173 matches)
Results (193 - 195 of 1173)
Ticket | Resolution | Summary | Owner | Reporter |
---|---|---|---|---|
#5624 | fixed | Cannot use sqlalchemy >= 1.4.0: set_models_as_attributes() troubles | ||
Description |
It seems to me that So, my new deployment of MediaGoblin explicitly pins sqlalchemy to a version that I know works for sure from a previous deployment (1.3.20) and just like that, the initial database migration works perfectly again. For whatever it's worth, here's the patch I applied in my copy of MediaGoblin: https://github.com/dressupgeekout/mediagoblin-dressupgeekout/commit/b85894dddc2d304f1aff05afce99d5dfa44b1b09 |
|||
#63 | fixed | Canonical place for giving credits to contributors | ||
Description |
We should start giving credit to everyone who's making GNU MediaGoblin a success (and not just people who do (c) assignment with the FSF). Where's the best place to put this? Assigning to Will, whom I know is presently overloaded, and can get to after Miro 4.0 gets out the door. |
|||
#5435 | fixed | Catch bad comment links to prevent server errors | ||
Description |
While debugging #5376, we noticed that attempting to access a comment which doesn't exist causes a server error. Ideally, we'd catch this and throw a 404 or just show the media page instead. Here's an example to illustrate the issue, but these links may go away soon :) There's an actual comment at this link. Following it works as expected. http://pumpdev.goblinrefuge.com/u/ayleph/m/doge/c/23/#comment Here I fat-fingered manually typing in the link, and I get a server error. http://pumpdev.goblinrefuge.com/u/ayleph/m/doge/c/123/#comment Here's what the error looks like. Error - <type 'exceptions.AttributeError'>: 'NoneType' object has no attribute 'id' URL: http://pumpdev.goblinrefuge.com/u/ayleph/m/doge/c/28/ File '/path/to/mediagoblin/lib/python2.7/site-packages/Paste-1.7.5.1-py2.7.egg/paste/exceptions/errormiddleware.py', line 144 in __call__ app_iter = self.application(environ, sr_checker) File '/path/to/mediagoblin/mediagoblin/app.py', line 342 in __call__ return self.call_backend(environ, start_response) File '/path/to/mediagoblin/lib/python2.7/site-packages/Werkzeug-0.9.6-py2.7.egg/werkzeug/wsgi.py', line 588 in __call__ return self.app(environ, start_response) File '/path/to/mediagoblin/mediagoblin/app.py', line 276 in call_backend return self._finish_call_backend(request, environ, start_response) File '/path/to/mediagoblin/mediagoblin/app.py', line 318 in _finish_call_backend response = controller(request) File '/path/to/mediagoblin/mediagoblin/decorators.py', line 47 in wrapper return controller(request, *args, **kwargs) File '/path/to/mediagoblin/mediagoblin/decorators.py', line 210 in wrapper return controller(request, media=media, *args, **kwargs) File '/path/to/mediagoblin/mediagoblin/decorators.py', line 170 in wrapper return controller(request, page=page, *args, **kwargs) File '/path/to/mediagoblin/mediagoblin/user_pages/views.py', line 135 in media_home mark_comment_notification_seen(comment_id, request.user) File '/path/to/mediagoblin/mediagoblin/notifications/__init__.py', line 75 in mark_comment_notification_seen obj_pk=comment.id, AttributeError: 'NoneType' object has no attribute 'id' |