Custom Query (1173 matches)
Results (232 - 234 of 1173)
Ticket | Resolution | Summary | Owner | Reporter |
---|---|---|---|---|
#648 | fixed | STL (3D) media type: buttons have redundant tooltips, one is wrong | ||
Description | ||||
#649 | fixed | Use form.field.data instead of request.form['field'] | ||
Description |
After submitting a form, our code needs to fetch the data from the form and put it to good use (update the db!). Our current code uses: form = EditForm(request.form) if ... and form.validate(): some_object.one_field = request.form.get('one_field') some_object_two_field = request.form['two_field'] This works mostly, but doesn't benefit from all the validation and cleanup that wtforms gives us. So this should be rewrittn to: form = EditForm(request.form) if ... and form.validate(): some_object.one_field = form.one_field.data some_object_two_field = form.two_field.data This can be done in small chunks on a file by file basis, or whatever fits someone wanting to work on this. No need to do all at once. Small changes are easier to review anyway. |
|||
#651 | fixed | Switch to Pillow? | ||
Description |
This has been mentioned by willkg in several previous bugs: #392 #57 (and one where someone mentioned it as a fix: #412) but maybe we should switch from PIL to Pillow; PIL seems to be better maintained: https://pypi.python.org/pypi/Pillow/ However, we shouldn't just make this switch without considering the implications. For example, we are currently shooting for Debian packaging, but Pillow is not packaged in Debian. Pillow is apparently backwards compatible though? |