This is (almost) the part 2 of the previous ticket.

If the template override system is to be modified, I believe it'd be a great idea to allow multiple themes and a customizable override order :

That would allow someone to make small design enhancement/mods without having to build a whole theme (perfect for plugins).

You would have to add those lines in the ini :

#the main theme
theme_base=base

#optional themes, each one override the previous one - that overide the base theme
theme[0]=my_theme
#if someone has made a theme for devices with screens smaller than 320px :
theme[1]=phone_theme
# some plugins would require to have this line added to the ini
plugin_theme[2]=my_plugin_1

That'd make theme and plugins way more flexible whith, at all time, a clean basic theme.

I needed a simple way to add and order JS and CSS, so instead of having them hard coded in "base.html" I made a list in the ini that is "foreached" in the template above.

Here's how this work :

in mediagoblin.ini, I've added three sections (css_files, js_header_files, js_footer_files (and allow me to stress the importance of footer js)) :

It look like this :

[js_header_files]
files = """
   /js/extlib/jquery.js
   /js/header_dropdown.js
"""

the """/""" allow multiple lines statements cause I want to be able to move lines up and down easily. "file_1="/"file_N=" is error prone and comma lists are unreadable.

In tools/templates.py I treat the data and send them as templates' context :

context['js_header_files'] = mg_globals.global_config.get('js_header_files', {})['files'].split()

And finally in "template/base.html", I display the data :

    {% for js_header_file in js_header_files %}
    {% set js_header_file  = request.staticdirect(js_header_file) %}
    <script src="{{js_header_file}}"></script>
    {% endfor %}

Smooth and easy.

./bin/gmg theme assetlink gives me this error :

  File "./bin/gmg", line 9, in <module>
    load_entry_point('mediagoblin==0.3.3.dev', 'console_scripts', 'gmg')()
  File "/var/www/mediagoblin/mediagoblin/gmg_commands/__init__.py", line 100, in main_cli
    args.func(args)
  File "/var/www/mediagoblin/mediagoblin/gmg_commands/theme.py", line 122, in theme
    SUBCOMMANDS[args.subcommand](args)
  File "/var/www/mediagoblin/mediagoblin/gmg_commands/theme.py", line 104, in assetlink_command
    link_assets(current_theme, app_config['theme_linked_assets_dir'])
  File "/var/www/mediagoblin/mediagoblin/gmg_commands/theme.py", line 71, in link_assets
    printer(_("No asset directory for this theme\n"))
  File "/var/www/mediagoblin/mediagoblin/tools/translate.py", line 122, in pass_to_ugettext
    return mg_globals.thread_scope.translations.ugettext(
AttributeError: 'NoneType' object has no attribute 'ugettext'