I just pulled down mediagoblin from git onto a new box and noticed that mediagoblin.ini has a couple of non-ASCII curly quotes in the comments. In fresh-out-of-the-box vim, it looks like:

# It defines types and defaults so it�~@~Ys a good place to look for documentation # or to find hidden options that we didn�~@~Yt tell you about. :)

Diff below.

--- mediagoblin.ini 2013-11-18 03:05:50.219990987 -0500 +++ mediagoblin-straightquotes.ini 2013-11-18 03:19:49.106257393 -0500 @@ -2,8 +2,8 @@

# mediagoblin_local.ini, then make the changes there. # # If you don't see what you need here, have a look at mediagoblin/config_spec.ini

-# It defines types and defaults so it’s a good place to look for documentation -# or to find hidden options that we didn’t tell you about. :) +# It defines types and defaults so it's a good place to look for documentation +# or to find hidden options that we didn't tell you about. :)

I set up GMG on a new site running postfix smtp server with ​postgrey greylisting. When GMG sends a verification email to a new user@domain address, the email is greylisted by my local smtp server and GMG throws an error. The accounts are created fine (they can still log in), and after waiting the requisite time for greylisting, my GMG instance can successfully email these addresses.

I've marked this as minor, as anyone who does encounter this will likely have configured greylisting on purpose and should be able to figure out how to fix it. However, it would be neat if GMG were aware of greylisting and had a slightly smarter behaviour. Perhaps instead of defaulting to a yeowch page, it could display a message such as "account was created but email could not be sent."

Logs follow with identifiable information scrubbed.

/var/log/mediagoblin/mediagoblin.log:

Starting server in PID 18739.
Error - <class 'smtplib.SMTPRecipientsRefused'>: {u'user@domain.tld': (450, '4.2.0 <user@domain.tld>: Recipient address rejected: "Greylisted')}
URL: http://domain.tld/auth/register/
File '/srv/mediagoblin/mediagoblin-0.6.2-dev/lib/python2.7/site-packages/Paste-1.7.5.1-py2.7.egg/paste/exceptions/errormiddleware.py', line 144 in __call__
  app_iter = self.application(environ, sr_checker)
File '/srv/mediagoblin/mediagoblin-0.6.2-dev/lib/python2.7/site-packages/Paste-1.7.5.1-py2.7.egg/paste/urlmap.py', line 203 in __call__
  return app(environ, start_response)
File '/srv/mediagoblin/mediagoblin-0.6.2-dev/mediagoblin/app.py', line 263 in __call__
  return self.call_backend(environ, start_response)
File '/srv/mediagoblin/mediagoblin-0.6.2-dev/mediagoblin/app.py', line 240 in call_backend
  response = controller(request)
File '/srv/mediagoblin/mediagoblin-0.6.2-dev/mediagoblin/decorators.py', line 303 in wrapper
  return controller(request, *args, **kwargs)
File '/srv/mediagoblin/mediagoblin-0.6.2-dev/mediagoblin/decorators.py', line 361 in wrapper
  return controller(request, *args, **kwargs)
File '/srv/mediagoblin/mediagoblin-0.6.2-dev/mediagoblin/auth/views.py', line 51 in register
  user = register_user(request, register_form)
File '/srv/mediagoblin/mediagoblin-0.6.2-dev/mediagoblin/auth/tools.py', line 148 in register_user
  send_verification_email(user, request)
File '/srv/mediagoblin/mediagoblin-0.6.2-dev/mediagoblin/auth/tools.py', line 103 in send_verification_email
  rendered_email)
File '/srv/mediagoblin/mediagoblin-0.6.2-dev/mediagoblin/tools/mail.py', line 129 in send_email
  return mhost.sendmail(from_addr, to_addrs, message.as_string())
File '/usr/lib64/python2.7/smtplib.py', line 735 in sendmail
  raise SMTPRecipientsRefused(senderrs)
SMTPRecipientsRefused: {u'user@domain.tld': (450, '4.2.0 <user@domain.tld>: Recipient address rejected: "Greylisted')}

/var/log/mail.log:

Feb  4 02:04:33 localhost postfix/smtpd[18751]: connect from localhost.localdomain[127.0.0.1]
Feb  4 02:04:33 localhost postgrey[14819]: action=greylist, reason=new, client_name=localhost.localdomain, client_address=127.0.0.1, sender=mediagoblin@localdomain, recipient=user@domain.tld
Feb  4 02:04:33 localhost postgrey[14819]: cleaning up old logs...
Feb  4 02:04:33 localhost postgrey[14819]: cleaning up old entries...
Feb  4 02:04:33 localhost postgrey[14819]: cleaning main database finished. before: 16, after: 3
Feb  4 02:04:33 localhost postgrey[14819]: cleaning clients database finished. before: 13, after: 2
Feb  4 02:04:33 localhost postfix/smtpd[18751]: NOQUEUE: reject: RCPT from localhost.localdomain[127.0.0.1]: 450 4.2.0 <user@domain.tld>: Recipient address rejected: "Greylisted; from=<mediagoblin@localdomain> to=<user@domain.tld> proto=ESMTP helo=<[xxx.xxx.xxx.xxx]>

While seeking through a video file to create a thumbnail, the pipeline (always?) passes the seek_amount argument as a float. This results in the DeprecationWarning: integer argument expected, got float warning shown below.

17:42:56,974 DEBUG   [mediagoblin.processing.task] Processing <MediaEntry 28: file>
17:42:56,974 INFO    [mediagoblin.media_types.video.transcoders] Initializing VideoTranscoder...
17:42:56,976 INFO    [mediagoblin.media_types.video.transcoders] Discovering /path/to/mediagoblin/user_dev/media/queue/media_entries/hash/file.webm
17:42:57,027 INFO    [mediagoblin.media_types.video.transcoders] Terminating MainLoop
17:42:57,028 DEBUG   [mediagoblin.media_types.video.processing] Skipping transcoding
17:42:57,089 INFO    [mediagoblin.media_types.video.transcoders] playbin ready
17:42:57,090 CRITICA [mediagoblin.media_types.video.transcoders] Could not get any video data from playbin
/path/to/mediagoblin/mediagoblin/media_types/video/transcoders.py:243: DeprecationWarning: integer argument expected, got float
  0)
17:42:57,118 INFO    [mediagoblin.media_types.video.transcoders] Could not seek.
/path/to/mediagoblin/mediagoblin/media_types/video/transcoders.py:243: DeprecationWarning: integer argument expected, got float
  0)
17:42:57,118 INFO    [mediagoblin.media_types.video.transcoders] Could not seek.
/path/to/mediagoblin/mediagoblin/media_types/video/transcoders.py:243: DeprecationWarning: integer argument expected, got float
  0)
17:42:57,118 INFO    [mediagoblin.media_types.video.transcoders] Could not seek.
/path/to/mediagoblin/mediagoblin/media_types/video/transcoders.py:243: DeprecationWarning: integer argument expected, got float
  0)
17:42:57,119 INFO    [mediagoblin.media_types.video.transcoders] Could not seek.
/path/to/mediagoblin/mediagoblin/media_types/video/transcoders.py:243: DeprecationWarning: integer argument expected, got float
  0)
17:42:57,119 INFO    [mediagoblin.media_types.video.transcoders] Could not seek.
/path/to/mediagoblin/mediagoblin/media_types/video/transcoders.py:243: DeprecationWarning: integer argument expected, got float
  0)
17:42:57,119 INFO    [mediagoblin.media_types.video.transcoders] Could not seek.
/path/to/mediagoblin/mediagoblin/media_types/video/transcoders.py:243: DeprecationWarning: integer argument expected, got float
  0)
17:42:57,120 INFO    [mediagoblin.media_types.video.transcoders] Could not seek.
/path/to/mediagoblin/mediagoblin/media_types/video/transcoders.py:243: DeprecationWarning: integer argument expected, got float
  0)
17:42:57,120 INFO    [mediagoblin.media_types.video.transcoders] Could not seek.
/path/to/mediagoblin/mediagoblin/media_types/video/transcoders.py:243: DeprecationWarning: integer argument expected, got float
  0)
17:42:57,121 INFO    [mediagoblin.media_types.video.transcoders] Could not seek.
/path/to/mediagoblin/mediagoblin/media_types/video/transcoders.py:243: DeprecationWarning: integer argument expected, got float
  0)
17:42:57,129 INFO    [mediagoblin.media_types.video.transcoders] Seek successful, attaching buffer probe
17:42:57,130 INFO    [mediagoblin.media_types.video.transcoders] Attached buffer probes: {'fakesink0': 75L}
17:42:57,219 INFO    [mediagoblin.media_types.video.transcoders] Taking snapshot! ((<GstPad (fakesink0:sink) at 7f606c211df0>, <gst.Buffer 0x7f607c006740 of size 54540 and data 0x56422e57>, 'fakesink0'))
17:42:57,282 INFO    [mediagoblin.media_types.video.transcoders] Saved snapshot!
17:42:57,297 DEBUG   [mediagoblin.media_types.video.processing] Saving thumbnail...