Custom Query (1173 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (250 - 252 of 1173)

Ticket Resolution Summary Owner Reporter
#5065 fixed skip_transcode never returns True anongoblin
Description

In mediagoblin/media_types/video/util.py, skip_transcode

The return type of tags.get_string is a tuple, (bool, value) (ref https://lazka.github.io/pgi-docs/Gst-1.0/structs/TagList.html#Gst.TagList.get_string) This code assumes that the return value is just a string. As such, it will always return False.

Example:

39 if configmime_types and tags.get_string('mimetype'): 40 if not tags.get_string('mimetype') in configmime_types: 41 return False

If there is no mimetype string in tags, then tags.get_string('mimetype') returns:

(False, None)

Which allows the test on line 40 to pass. Of course, (False, None) does not appear in the list of mimetypes in the config.

In each case, the initial existence test needs a [0] after the get_string, and the second test needs a [1] after the get_string. E.g.:

39 if configmime_types and tags.get_string('mimetype')[0]: 40 if not tags.get_string('mimetype')[1] in configmime_types: 41 return False

(raised as anongoblin as registration is disabled)

#5062 fixed which bower > /dev/null doesn't redirect stderr ayleph
Description

devtools/update_extlib.sh uses which to look for bower in $PATH. However, it doesn't redirect stderr to /dev/null, so the user sees a misleading message if bower does not exist in $PATH. This causes the user to think that bower is being reinstalled every time devtools/update_extlib.sh runs.

#5060 wontfix The remote end hung up unexpectedly vladopc
Description

After

git clone git://gitorious.org/mediagoblin/mediagoblin.git -b stable

I got :

Cloning into 'mediagoblin'... fatal: The remote end hung up unexpectedly

Batch Modify
Note: See TracBatchModify for help on using batch modify.
Note: See TracQuery for help on using queries.