Custom Query (1173 matches)
Results (157 - 159 of 1173)
Ticket | Resolution | Summary | Owner | Reporter |
---|---|---|---|---|
#5403 | fixed | Use upstream version of freesound | ||
Description |
#5333 was closed by changing freesound in extlib. This is not the best thing to do; the best would be to use upstream version without modification (see extlib/README). This ticket is here to verify that we use the same code upstream has. Pull request to upstream: https://github.com/MTG/freesound/pull/700 |
|||
#5402 | fixed | no instructions for python3 | ||
Description |
Current instructions are for python2. Some packages in debian repos are not python-*, but python3-*. |
|||
#5401 | fixed | Video processing fails when media contains no tags | ||
Description |
The /path/to/mediagoblin/mediagoblin/media_types/video/transcoders.py:34: PyGIWarning: GstPbutils was imported without specifying a version first. Use gi.require_version('GstPbutils', '1.0') before import to ensure that the right version gets loaded. from gi.repository import GObject, Gst, GstPbutils DEBUG:mediagoblin.processing.task:Processing <MediaEntry 7016: Cartel para adopción> ERROR:mediagoblin.processing.task:An unhandled exception was raised while processing <MediaEntry 7016: Cartel para adopción> WARNING:mediagoblin.processing:No idea what happened here, but it failed: AttributeError("'NoneType' object has no attribute 'get_string'",) WARNING:mediagoblin.processing:No idea what happened here, but it failed: AttributeError("'NoneType' object has no attribute 'get_string'",) Traceback (most recent call last): File "bin/gmg", line 9, in <module> load_entry_point('mediagoblin', 'console_scripts', 'gmg')() File "/path/to/mediagoblin/mediagoblin/gmg_commands/__init__.py", line 142, in main_cli args.func(args) File "/path/to/mediagoblin/mediagoblin/gmg_commands/reprocess.py", line 293, in reprocess run(args) File "/path/to/mediagoblin/mediagoblin/gmg_commands/reprocess.py", line 205, in run reprocess_info=reprocess_request) File "/path/to/mediagoblin/mediagoblin/submit/lib.py", line 261, in run_process_media task_id=entry.queued_task_id) File "/path/to/mediagoblin/lib/python2.7/site-packages/celery-3.1.17-py2.7.egg/celery/app/task.py", line 547, in apply_async link=link, link_error=link_error, **options) File "/path/to/mediagoblin/lib/python2.7/site-packages/celery-3.1.17-py2.7.egg/celery/app/task.py", line 739, in apply request=request, propagate=throw) File "/path/to/mediagoblin/lib/python2.7/site-packages/celery-3.1.17-py2.7.egg/celery/app/trace.py", line 355, in eager_trace_task uuid, args, kwargs, request) File "/path/to/mediagoblin/lib/python2.7/site-packages/celery-3.1.17-py2.7.egg/celery/app/trace.py", line 253, in trace_task I, R, state, retval = on_error(task_request, exc, uuid) File "/path/to/mediagoblin/lib/python2.7/site-packages/celery-3.1.17-py2.7.egg/celery/app/trace.py", line 240, in trace_task R = retval = fun(*args, **kwargs) File "/path/to/mediagoblin/mediagoblin/processing/task.py", line 101, in run processor.process(**reprocess_info) File "/path/to/mediagoblin/mediagoblin/media_types/video/processing.py", line 396, in process vp8_threads=vp8_threads, vorbis_quality=vorbis_quality) File "/path/to/mediagoblin/mediagoblin/media_types/video/processing.py", line 265, in transcode if skip_transcode(metadata, medium_size): File "/path/to/mediagoblin/mediagoblin/media_types/video/util.py", line 37, in skip_transcode if config['mime_types'] and tags.get_string('mimetype')[0]: AttributeError: 'NoneType' object has no attribute 'get_string' Here's a proposed fix. But I guess the question is, is it valid to have video with tag metadata? If not, then something else may be wrong (bad video file, or perhaps the wrong media type is trying to process the file). diff --git a/mediagoblin/media_types/video/util.py b/mediagoblin/media_types/video/util.py index d3d2927..e35b021 100644 --- a/mediagoblin/media_types/video/util.py +++ b/mediagoblin/media_types/video/util.py @@ -34,6 +34,9 @@ def skip_transcode(metadata, size): _log.debug('skip_transcode config: {0}'.format(config)) tags = metadata.get_tags() + if not tags: + return False + if config['mime_types'] and tags.get_string('mimetype')[0]: if not tags.get_string('mimetype')[1] in config['mime_types']: return False |