Custom Query (1173 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (130 - 132 of 1173)

Ticket Resolution Summary Owner Reporter
#5440 fixed Typo in blog views ayleph
Description
--- a/mediagoblin/media_types/blog/views.py
+++ b/mediagoblin/media_types/blog/views.py
@@ -313,7 +313,7 @@ def blog_delete(request, **kwargs):
     blog_slug = request.matchdict.get('blog_slug', None)
     blog = get_blog_by_slug(request, blog_slug, author=owner_user.id)
     if not blog:
-        return render_404(reequest)
+        return render_404(request)

     form = blog_forms.ConfirmDeleteForm(request.form)
     if request.user.id == blog.author or request.user.has_privilege(u'admin'):
#5436 fixed Add "gmg raw_alembic" command Christopher Allan Webber
Description

For certain types of tasks, it's helpful (and perhaps necessary) to be able to use Alembic's own tooling. We don't want users to have to use this often, but it's particularly helpful for developers. In particular, solving #5424 will probably require having access to Alembic's tool.

Attached is a patch which adds a gmg raw_alembic command. It's not recommended that everyone use it, but now it's an available option.

#5435 fixed Catch bad comment links to prevent server errors ayleph
Description

While debugging #5376, we noticed that attempting to access a comment which doesn't exist causes a server error. Ideally, we'd catch this and throw a 404 or just show the media page instead.

Here's an example to illustrate the issue, but these links may go away soon :)

There's an actual comment at this link. Following it works as expected.

http://pumpdev.goblinrefuge.com/u/ayleph/m/doge/c/23/#comment

Here I fat-fingered manually typing in the link, and I get a server error.

http://pumpdev.goblinrefuge.com/u/ayleph/m/doge/c/123/#comment

Here's what the error looks like.

Error - <type 'exceptions.AttributeError'>: 'NoneType' object has no attribute 'id'
URL: http://pumpdev.goblinrefuge.com/u/ayleph/m/doge/c/28/
File '/path/to/mediagoblin/lib/python2.7/site-packages/Paste-1.7.5.1-py2.7.egg/paste/exceptions/errormiddleware.py', line 144 in __call__
  app_iter = self.application(environ, sr_checker)
File '/path/to/mediagoblin/mediagoblin/app.py', line 342 in __call__
  return self.call_backend(environ, start_response)
File '/path/to/mediagoblin/lib/python2.7/site-packages/Werkzeug-0.9.6-py2.7.egg/werkzeug/wsgi.py', line 588 in __call__
  return self.app(environ, start_response)
File '/path/to/mediagoblin/mediagoblin/app.py', line 276 in call_backend
  return self._finish_call_backend(request, environ, start_response)
File '/path/to/mediagoblin/mediagoblin/app.py', line 318 in _finish_call_backend
  response = controller(request)
File '/path/to/mediagoblin/mediagoblin/decorators.py', line 47 in wrapper
  return controller(request, *args, **kwargs)
File '/path/to/mediagoblin/mediagoblin/decorators.py', line 210 in wrapper
  return controller(request, media=media, *args, **kwargs)
File '/path/to/mediagoblin/mediagoblin/decorators.py', line 170 in wrapper
  return controller(request, page=page, *args, **kwargs)
File '/path/to/mediagoblin/mediagoblin/user_pages/views.py', line 135 in media_home
  mark_comment_notification_seen(comment_id, request.user)
File '/path/to/mediagoblin/mediagoblin/notifications/__init__.py', line 75 in mark_comment_notification_seen
  obj_pk=comment.id,
AttributeError: 'NoneType' object has no attribute 'id'
Batch Modify
Note: See TracBatchModify for help on using batch modify.
Note: See TracQuery for help on using queries.