We store some global variables in mediagoblin.mg_globals, though a couple of them are just pulled right out of the application config, which is already stored in mediagoblin.mg_globals.app_config anyway. So that's unnecessary duplication.

So there are a few steps to this.

• In mediagoblin/mg_globals.py find the email_debug_mode and email_sender_address defaults lines, and remove them (and their comments too)
• In mediagoblin/app.py find the section that has the setup_globals() call, and remove the couple of lines that specify email_sender_address and email_debug_mode from the app_config
• grep for any instances of mg_globals.email_sender_address and change to mg_globals.app_config['email_sender_address'] ... probably just in mediagoblin/auth/lib.py
• grep for any instances of mg_globals.email_debug_mode and change to mg_globals.app_config['email_debug_mode'] ... probably all in mediagoblin/util.py
• Make sure tests pass still with ./bin/nosetests

mediagoblin/util.py is like our junk drawer for any functionality we want to abstract out of a particular view, and it's starting to get ugly. At present, it contains methods related to: testing, templating, request processing, user sessions, dynamic component importing, urls/slugs, email, translation, data sanitizing,and pagination. Most of these categories are functionally distinct from the others and could be separated out into different files according to category, e.g.:

mediagoblin/tools - tests.py - templates.py - requests.py - text_processing.py - etc.

Once a structure is decided upon, imports referencing util.py will have to be updated.

I should add a docstring for each model in models.py explaining what each field in the structure is and how it should be used.