Custom Query (1173 matches)
Results (151 - 153 of 1173)
Ticket | Resolution | Summary | Owner | Reporter |
---|---|---|---|---|
#153 | FIXED | No need for email_sender_address / email_debug_mode in mediagoblin.mg_globals | ||
Description |
We store some global variables in mediagoblin.mg\_globals, though a couple of them are just pulled right out of the application config, which is already stored in mediagoblin.mg\_globals.app\_config anyway. So that's unnecessary duplication. So there are a few steps to this. - In mediagoblin/mg\_globals.py find the email\_debug\_mode and email\_sender\_address defaults lines, and remove them (and their comments too) - In mediagoblin/app.py find the section that has the setup\_globals() call, and remove the couple of lines that specify email\_sender\_address and email\_debug\_mode from the app\_config - grep for any instances of mg\_globals.email\_sender\_address and change to mg\_globals.app\_config['email\_sender\_address'] ... probably just in mediagoblin/auth/lib.py - grep for any instances of mg\_globals.email\_debug\_mode and change to mg\_globals.app\_config['email\_debug\_mode'] ... probably all in mediagoblin/util.py - Make sure tests pass still with ./bin/nosetests |
|||
#154 | FIXED | util.py is cluttered | ||
Description |
mediagoblin/util.py is like our junk drawer for any functionality we want to abstract out of a particular view, and it's starting to get ugly. At present, it contains methods related to: testing, templating, request processing, user sessions, dynamic component importing, urls/slugs, email, translation, data sanitizing,and pagination. Most of these categories are functionally distinct from the others and could be separated out into different files according to category, e.g.: mediagoblin/tools - tests.py - templates.py - requests.py - text\_processing.py - etc. Once a structure is decided upon, imports referencing util.py will have to be updated. |
|||
#155 | FIXED | Models in models.py undocumented | ||
Description |
I should add a docstring for each model in models.py explaining what each field in the structure is and how it should be used. |
Note:
See TracQuery
for help on using queries.